search

DMTF / Redfish-Event-Listener

The Redfish Event Listener is a lightweight HTTPS server that can be deployed to read and record events from Redfish services.
Other
31 stars 17 forks source link

Update to use Redfish libraries and spelling fixes #17

Closed tomasg2012 closed 2 years ago

tomasg2012 commented 2 years ago

Fix #10 Fix #11 Fix #12 Fix #13

tomasg2012 commented 2 years ago

Hadn't completely investigated the IPV4/6 situation and was going to give it a good look when the day started, I'll have a code tweak. This is in tandem with any deprecated event payload keys, but that might take longer.

On Mon, Jan 31, 2022, 8:17 AM Mike Raineri @.***> wrote:

@.**** commented on this pull request.

In RedfishEventListener_v1.py https://github.com/DMTF/Redfish-Event-Listener/pull/17#discussion_r795711226 :

  • my_logger.info("Subcription is not successful for %s or it is already present." % dest)
  • target_contexts.append(my_ctx)
  • except Exception as e:
  • my_logger.info('Issue creating our ctx')
  • my_logger.info(traceback.print_exc())
  • target_contexts.append(None)
  • my_logger.info("Continuing with Listener.")

  • Accept the TCP connection using certificate validation using Socket wrapper

  • useSSL = config['usessl']
  • if useSSL:
  • context = ssl.create_default_context(ssl.Purpose.CLIENT_AUTH)
  • context.load_cert_chain(certfile=config['certfile'], keyfile=config['keyfile'])

  • Bind socket connection and listen on the specified port

  • bindsocket = socket.socket()

I think this method of making a socket still limits us to IPv4.

— Reply to this email directly, view it on GitHub https://github.com/DMTF/Redfish-Event-Listener/pull/17#pullrequestreview-867903220, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKQIXEE5Q4VMEOEC3IGWLTUY2KW5ANCNFSM5NB43TOA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

mraineri commented 2 years ago

Approved 2/25