DMTF / Redfish-Mockup-Server

A simple Python 3.4 program that can be copied into a folder at the top of any Redfish mockup and can serve Redfish requests on the specified IP/port.
Other
72 stars 37 forks source link

CORS support #86

Closed donzef closed 2 years ago

donzef commented 2 years ago

Question:

I noticed that CORS (Cross-origin Resource Sharing) support has been removed silently in version 1.0.9. This feature allows JavaScript GUI simulators calling the Redfish-Mokcup-Server and providing a full BMC simulator (GUI + Redfish service).

Any chance to have it back ?

Thanks.

mraineri commented 2 years ago

Do you know what version this was last working? I wasn't aware we ever had CORS support previously, and going through the pull requests merged up through 1.0.9 nothing sticks out to me as to when something like this was removed.

donzef commented 2 years ago

CORS support was in version 1.0.8. It is not there in version 1.0.9.

image

mraineri commented 2 years ago

I've been looking through the assets attached to the releases (https://github.com/DMTF/Redfish-Mockup-Server/releases) and I can't find the same references you're seeing for version 1.0.8 and 1.0.7. Could those have been added by someone after downloading the source from GitHub?

donzef commented 2 years ago

<<<Could those have been added by someone after downloading the source from GitHub?>>> This is the only possibility !

I'll investigate on my side where I got this code from.... Closing for now.

Sorry.