search

DMTF / Redfish-Protocol-Validator

The Redfish Protocol Validator tests the HTTP protocol behavior of a Redfish service to validate that it conforms to the Redfish specification.
Other
14 stars 12 forks source link

About REQ_PATCH_ARRAY_TRUNCATE #30

Closed JojoWu19 closed 3 years ago

JojoWu19 commented 3 years ago

This test case check if the array of response is the same with expected_array but it will report below cases failed.

  1. fixed length array: there are null members are appended in the end of array.
  2. the member has default value: some implemetations have default value for members, for example: "" or "0.0.0.0". If the member is deleted, it is given the default value.

I don't sure if the case 2 conforms to spec but validator should let case 1 pass, right?

mraineri commented 3 years ago

For item 1, I think you're correct; we'll need to look more into this.

For item 2, using an empty string, 0.0.0.0, or some other dummy data is generally discouraged and can lead to interoperability problems. We expect clients to be explicitly looking for null in array slots to understand where something new can be inserted. We're seen issues with this in the EthernetInterface resource, which lead us to produce a use case checker to verify implementations are following the proper patterns we put in the specification.

JojoWu19 commented 3 years ago

Get it, thank you.

mraineri commented 3 years ago

@JojoWu19 could you please try the Array-Test-Fixes branch? I don't have a system that performs the null padding at the end of the array to verify this myself.

JojoWu19 commented 3 years ago

@mraineri It is passed in my side, and here is the debug log: debug.txt