DMTF / Redfish-Protocol-Validator

The Redfish Protocol Validator tests the HTTP protocol behavior of a Redfish service to validate that it conforms to the Redfish specification.
Other
14 stars 12 forks source link

SERV_SSE_EVENT_DEST_DELETED_ON_CLOSE should wait much longer than 3 seconds #47

Closed blakehilliard closed 1 year ago

blakehilliard commented 1 year ago

I'm seeing this tool assert that SERV_SSE_EVENT_DEST_DELETED_ON_CLOSE fails, but that's only because it gives up after 3 seconds of closing the client side of the SSE connection.

At least in the framework I use for redfish SSE (WSGI), a close of the SSE client is only recognized on the next attempt to write to that connection, which will be on the next SSE heartbeat if no event occurs. And 3 seconds seems quite short for SSE heartbeat events to occur? Mine can take up to 20 seconds.

mraineri commented 1 year ago

By "SSE heartbeat", do you mean the socket keep-alive mechanism? I wouldn't expect explicit heartbeat messages sent over SSE since that should all be handled by the socket's keep-alive method itself.

blakehilliard commented 1 year ago

By "heartbeat" I only mean sending a comment (line that starts with a colon) across the connection every now and then if there haven't been any events. This part of the redfish spec: A service may occasionally send a comment within a stream to keep the connection alive

mraineri commented 1 year ago

Gotcha, thanks for clarifying