search

DMTF / Redfish-Protocol-Validator

The Redfish Protocol Validator tests the HTTP protocol behavior of a Redfish service to validate that it conforms to the Redfish specification.
Other
14 stars 12 forks source link

Fix tests for PasswordChangeRequired #64

Closed kriegeraa closed 7 months ago

kriegeraa commented 1 year ago

requests calls were missing the verify argument. PATCH to change password was not using whole URI.

Fixes PasswordChangeRequired tests when using --no-cert-check argument and fixes the change password test when PasswordChangeRequired can be tested.

mraineri commented 1 year ago

Would you be able to provide the HTML reports for the system you're testing before your changes were introduced and after your changes were made? I'd like to see the difference, and unfortunately I don't have access to a system with the "password change required" behavior.

kriegeraa commented 7 months ago

Sorry, I cannot provide the HTML reports. (In this case, I feel they are not very helpful anyway.) This fix is very trivial however, so I hope you can just take a look at the changes. I think if you compare it with the code around, you will see it's just adding some parts that were simply forgotten in these functions.

mraineri commented 7 months ago

I'll take a look before we do approvals tomorrow to see if I can line up what's really going on in this flow.

mraineri commented 7 months ago

Okay, this definitely threw me off for a bit when I first looked at it, but now I understand what this does.

We should have this merged later today.

mraineri commented 7 months ago

Approved 1/19