search

DMTF / Redfish-Protocol-Validator

The Redfish Protocol Validator tests the HTTP protocol behavior of a Redfish service to validate that it conforms to the Redfish specification.
Other
14 stars 12 forks source link

/archive/reds/tags/{file}.zip points to a different version as the name of the {file}. #70

Closed leoprovido closed 1 year ago

leoprovido commented 1 year ago

Hi @mraineri ,

In https://github.com/DMTF/Redfish-Protocol-Validator/releases, I noticed that when I download https://github.com/DMTF/Redfish-Protocol-Validator/archive/refs/tags/1.1.9.zip, the downloaded zip file appears to be 1.1.8.

image

I don't see this behavior in other repositories like https://github.com/DMTF/Redfish-Interop-Validator/releases. For example, https://github.com/DMTF/Redfish-Interop-Validator/archive/refs/tags/2.1.4.zip

image

mraineri commented 1 year ago

I'm seeing the same issue on the service validator... The interop validator is using a slightly different workflow for making a release, which I'm actually changing to be more consistent with what appears to be the "right" method (using the actions/create-release). It seems like the versioning/changelog updates pushed in the previous step don't get picked up by the action... Will need to look at this more...

mraineri commented 1 year ago

Well, I just noticed the repo for that action is marked as read-only and unmaintained... I think I'll use the same workflow step used in the interop validator to make the release.

mraineri commented 1 year ago

Made this change to address this: https://github.com/DMTF/Redfish-Protocol-Validator/commit/356b97ec9edc0e4b1953f9af1af682ab7ae7a6b0

I ran the publication action again and everything is in sync; thanks for catching this!