search

DMTF / Redfish-Service-Validator

The Redfish Service Validator is a Python3 tool for checking conformance of any "device" with a Redfish service interface against Redfish CSDL schema
Other
38 stars 33 forks source link

Fixes access to None object in validateEntity #522

Closed tomasg2012 closed 1 year ago

tomasg2012 commented 1 year ago

Fix #520

mraineri commented 1 year ago

@tomasg2012 what sort of conditions did this correct? Trying to understand what sort of behavior on the Redfish service shows the original issue?

tomasg2012 commented 1 year ago

This doesn't change any major behavior except for getting the response status from an object that isn't None. If a URI happened to be incorrect or the service failed at this step, it now wont cause an Exception.

mraineri commented 1 year ago

Got it, thanks.

Any thoughts on how to construct a set of mockups to simulate this?

tomasg2012 commented 1 year ago

In any situation where a response would be None, and I think this would Only happen if the service experienced an exception. This occurs in traverse.rfService.callResourceURI, and seems to have happened when retries were exhausted. Not sure if the mockup can simulate this unless you terminated it manually during execution while validating any payload with links to Entities.

jautor commented 1 year ago

Approved 2/3