DMTF / Redfish-Service-Validator

The Redfish Service Validator is a Python3 tool for checking conformance of any "device" with a Redfish service interface against Redfish CSDL schema
Other
38 stars 33 forks source link

Mandatory Property Error #526

Closed SelviRaju closed 1 year ago

SelviRaju commented 1 year ago

Hi All,

For Power Subsystem showing mandatory property as below

image

But in validator thorwing error for redundancy group

image

image

Please confirm whether Redundancy group as mandatory if yes where we can confirm.

Thanks & Regards, R.Selvi

jautor commented 1 year ago

You'll see the mandatory ("required" term in JSON schema) properties for the RedundancyGroup in the Redundancy schema referenced by PowerSubsystem.

If your PowerSubsystem resource contains a PowerSupplyRedundancy property, then yes, the RedundancyType, MinNeededInGroup, Status, and RedundancyGroup are all required properties.

If your resource does NOT contain the PowerSupplyRedundancy property, then that would be a tool issue. But that pattern of referenced definitions containing required properties appears in other places throughout the model, so I'd expect the tool is handling that correctly.

mraineri commented 1 year ago

@jautor is correct; it looks like your service is returning the "PowerSupplyRedundancy" property but is not providing "RedundancyGroup".

Can you please provide the payload for your resource to confirm? This looks like a conformance issue with the service.

mraineri commented 1 year ago

@SelviRaju were you able to follow up with your implementation to see what's in the payload?

mraineri commented 1 year ago

Closing; based on the existing details, this appears to be a service-side error.

If there are additional details that show otherwise, please reopen.