DMTF / Redfish-Service-Validator

The Redfish Service Validator is a Python3 tool for checking conformance of any "device" with a Redfish service interface against Redfish CSDL schema
Other
38 stars 33 forks source link

Error: URI does not match object IDs of resource chain with Oem #537

Closed zkurzyns closed 1 year ago

zkurzyns commented 1 year ago

Hi. using the latest version of validator I am getting the error bellow.

ERROR - URI /redfish/v1/Managers/bmc/Oem/CompanyX/ServiceY does not match object IDs of resource chain.

Redfish.Uris is constructed like this:

<Annotation Term="Redfish.Uris">
  <Collection>
    <String>/redfish/v1/Managers/{ManagerId}/Oem/CompanyX/ServiceY</String>
  </Collection>
</Annotation>

and the response to mentioned URL has properties defined like below:

{
"Id": "ServiceY",
"Name": "Service Y",
...
}

With other URIs where there is no Oem/ subtree I do not see this error.

This error was not see with previous validator version. is it regression or some of my schemas/implementation needs upgrade?

mraineri commented 1 year ago

We have two issues opened around this (#533 and #531). We're currently trying to address this with #536; please stay tuned

mraineri commented 1 year ago

@zkurzyns could you please try out the change from the referenced PR? It's available in the main branch (and version 2.2.5)

zkurzyns commented 1 year ago

Running version 2.2.4 I am getting mentioned error on each subtree element of my service for example: /redfish/v1/Managers/bmc/Oem/CompanyX/ServiceY /redfish/v1/Managers/bmc/Oem/CompanyX/ServiceY/a /redfish/v1/Managers/bmc/Oem/CompanyX/ServiceY/b /redfish/v1/Managers/bmc/Oem/CompanyX/ServiceY/b/c ...

With release 2.2.5 it is a bit better. I am getting the error only on the root element on my service and all sub elements have PASSes.

mraineri commented 1 year ago

Thanks; there's still additional cleanup we're doing now that addresses other false positives.

Are you able to try the branch uri-remove-toggle? This seems to address the other false positives I've been finding.

zkurzyns commented 1 year ago

Hi Mike, this branch uri-remove-toggle looks promising. I do not get any false positive errors:)

mraineri commented 1 year ago

Thanks for checking! When you're comfortable with the changes, please close the issue.

zkurzyns commented 1 year ago

Thank you for quick and effective support :) Closing this issue.