search

DMTF / Redfish-Service-Validator

The Redfish Service Validator is a Python3 tool for checking conformance of any "device" with a Redfish service interface against Redfish CSDL schema
Other
38 stars 33 forks source link

False positives for URI checking on public-rackmount1 mockup #538

Closed mraineri closed 1 year ago

mraineri commented 1 year ago

From PR #536

@tomasg2012 I'm seeing mixed results when I test against the public-rackmount1 mockup found in this bundle: https://www.dmtf.org/sites/default/files/standards/documents/DSP2043_2022.3.zip

Some of the failures are real and need to be fixed in the mockup, but these resources look correct to me (but the test report shows a "failRedfishUriStrict" error). Please take a look at the report for these URIs:

ConformanceLog_02_10_2023_203011.txt

ConformanceHtmlLog_02_10_2023_203011.html.txt

tomasg2012 commented 1 year ago

In reference to this, both /redfish/v1/Chassis/1U/Sensors/CPU1Temp and /redfish/v1/Systems/437XR1138R2/Certificates/contoso-subca are positives. The rest however, I can attribute to a particular piece of code that toggles uri checking if the program detects an annotation: however, I don't have any precedent for why this is the case, and removing it doesn't seem to cause issue. It may need to be reworked. For now, removing these lines fixes the issue.

mraineri commented 1 year ago

Yup, those two URIs are definitely invalid. If you have a branch, I can do testing on my end too.