search

DMTF / Redfish-Service-Validator

The Redfish Service Validator is a Python3 tool for checking conformance of any "device" with a Redfish service interface against Redfish CSDL schema
Other
37 stars 33 forks source link

Fix to Action validation overriding variable name, added log entry #549

Closed tomasg2012 closed 1 year ago

tomasg2012 commented 1 year ago

Prevents overriding the error entry in messages

Added log entry for actions with bad names.

Fixes #513

mraineri commented 1 year ago

Looking over the output log, I see "errorActionBadName" tallied at the top, and I also see "errorActionBadName" in the summary of the affected resource, but I don't see it called out in the more specific errors details.

So, for example, I took public-rackmount1, and changed #ComputerSystem.Reset to #ComputerSystem.Fred in the system mockup.

At the top of the report I see "errorActionBadName" in the first block, but nothing calling it out for a specific URI in the second block like other errors.

image

And then in the URI report, I see the error on the right, which is good:

image

But when expanding the URI report, there's no mention of the error:

image

tomasg2012 commented 1 year ago

Couldn't seem to find the problem with the message not appearing in the Error Logging block, so I am unsure if there's more to it. if the branch still doesn't work, please post any more info.

mraineri commented 1 year ago

Updates look good! Haven't found a regression yet

mraineri commented 1 year ago

Approved 3/17