DMTF / Redfish-Service-Validator

The Redfish Service Validator is a Python3 tool for checking conformance of any "device" with a Redfish service interface against Redfish CSDL schema
Other
37 stars 33 forks source link

"Tree" usage for testing every links #567

Closed Againxarcher closed 4 months ago

Againxarcher commented 8 months ago

Hi,

I tried to give "tree" for payload argument to run the validator. image

So it will be test all links under "/redfish/v1/Systems/Self/NetworkInterfaces". image image

But I observed the next link under "/redfish/v1/Systems/Self/NetworkInterfaces/DevType7_NIC0" didn't be run. image

Shall it be run or this is normally behavior?

Here is the attached report for reference. 1024.zip

mraineri commented 8 months ago

Yes, this is correct behavior. Because that link is inside of the "Links" object, it's not considered subordinate to the resource, and therefore is not considered part of the tree.

In most URIs for Redfish, you can visualize this just from the URI itself. For example, everything starting with "/redfish/v1/Chassis/1/PowerSubsystem" would be considered subordinate to Chassis 1's PowerSubsystem resource and is therefore in the tree. However, the advanced comm device model has some cross linking for ease of expansion, such as how the "Ports" collection beneath a NetworkInterface resource contains members within the Chassis URI pattern. However, since "Ports" is not inside of "Links", it's treated as part of the resource tree, and is then tested.

Againxarcher commented 8 months ago

Got it, Thanks.