search

DMTF / Redfish-Service-Validator

The Redfish Service Validator is a Python3 tool for checking conformance of any "device" with a Redfish service interface against Redfish CSDL schema
Other
44 stars 34 forks source link

Redfish Validator now flags link to Assembly #599

Open baemyung opened 3 months ago

baemyung commented 3 months ago

The latest Redfish Service Validator change https://github.com/DMTF/Redfish-Service-Validator/commit/ab8e447a713d0afa138a4ed3c20a2ed0dd497249 verifies the links.

We have the following link in Cables: 

"DownstreamResources": [
            {
                "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/17"
            }
        ],

Which throws the error: 

Links.DownstreamResources[0]    Link: /redfish/v1/Chassis/chassis/Assembly#/Assemblies/24   link: Resource  Yes FAIL

ERROR - DownstreamResources: Linked resource is not the correct type; found Assembly.v1_3_0.AssemblyData, expected Resource.Resource

We have a bunch of Simple Inventory (Field Replaceable Units (FRUs)) that we model as Assemblies... They have properties like an Identify LED, Part Number, but not much else. In this case, the Downstream Resource is a DASD (direct access storage device) Backplane.

Can Cable DownstreamResouces allow for Assembly.AssemblyData ?

mraineri commented 3 months ago

"DownstreamResources" is defined as "Resource.Resource" to point to any resource in the model. However, "AssemblyData" in Assembly is NOT a resource; it's a "referenceable member" object. So, no, DownstreamResources cannot be used to point to an individual AssemblyData like that.

mraineri commented 3 months ago

Now, maybe there's a broader modeling question we need to ask the Redfish Forum; should we change the DownstreamResources link to allow for referenceable member objects?

baemyung commented 3 months ago

@mraineri Thanks for explaining the cause. What should I do to go forward asking the modeling question?

mraineri commented 3 months ago

@mraineri Thanks for explaining the cause. What should I do to go forward asking the modeling question?

I've raised this for further review internally. You don't need to do anything directly, but since you're a DMTF member, you can see the discussions going on.