search

DMTF / Redfishtool

A Python34 program that implements a command line tool for accessing the Redfish API.
Other
224 stars 68 forks source link

Set Bootsourceoveridemode explicitly while setting bootoverride . #106

Closed rahulagnihotri closed 1 year ago

rahulagnihotri commented 1 year ago

Set Bootsourceoveridemode explicitly while setting bootoverride .This is needed as some vendors like Supermicro don't respect the existing overridemode value , instead they revert to default value if it is not explicitly passed .

mraineri commented 1 year ago

Have you contacted Supermicro about this? That sort of behavior is a bug in the service that needs to be fixed. Redfish does not require users to echo back properties in PATCH requests that they do not want to modify.

I don't mind having a workaround in place to make it easier for you, but this type of issue does concern me if the vendor is not aware of the problem.

rahulagnihotri commented 1 year ago

Yes we had a detailed meeting/discussion with Supermicro as well . We stated the same to them "Redfish does not need to pass properties , which are not intended to be modified" . But they came back saying that it is as per their design . Their Redfish design has to follow their BMC design spec , which somehow always expect this value to be passed . So they don't acknowledge this as bug , instead they claim this is how their system is designed . And I don't see them fixing it anytime soon.

So it would be better if we get this commit merged , so it becomes easier for us to use redfishtoollib for Supermicro servers as well.

Thanks Rahul A

mraineri commented 1 year ago

We can still accept this change as a workaround, but I'm very concerned Supermicro is not recognizing this as a bug. This is a core RESTful tenet to follow.

mraineri commented 1 year ago

@isanlam FYI

rahulagnihotri commented 1 year ago

@mraineri @isanlam : Do you have any further comments on it? If not can you pls accept and merge the change

mraineri commented 1 year ago

Approved 6/30.

Will follow up with @isanlam offline to ensure we're not going to encourage bad service behavior. The group agrees this is certainly a bug with the Supermicro implementation.