search

DMTF / Redfishtool

A Python34 program that implements a command line tool for accessing the Redfish API.
Other
231 stars 69 forks source link

Suggestion: add wheel package #51

Closed thombashi closed 6 years ago

thombashi commented 6 years ago

Wheel package is installable for both Linux and Windows users. I confirmed that a wheel package which created from the redfishtool repository can be also installed on Windows environments:

Redfishtool\dist>pip install redfishtool-1.0.5-py3-none-any.whl
Processing g:\workspace\githubdesktop\redfishtool\dist\redfishtool-1.0.5-py3-none-any.whl
Requirement already satisfied: requests in c:\python36\lib\site-packages (from redfishtool==1.0.5) (2.19.1)
Requirement already satisfied: chardet<3.1.0,>=3.0.2 in c:\python36\lib\site-packages (from requests->redfishtool==1.0.5) (3.0.4)
Requirement already satisfied: certifi>=2017.4.17 in c:\python36\lib\site-packages (from requests->redfishtool==1.0.5) (2018.4.16)
Requirement already satisfied: idna<2.8,>=2.5 in c:\python36\lib\site-packages (from requests->redfishtool==1.0.5) (2.7)
Requirement already satisfied: urllib3<1.24,>=1.21.1 in c:\python36\lib\site-packages (from requests->redfishtool==1.0.5) (1.23)
Installing collected packages: redfishtool
Successfully installed redfishtool-1.0.5

This would solve issue #28. You may need to change the release process a little bit, for example:

$ python setup.py sdist bdist_wheel  # build packages for both tarball and wheel package
...
$ ls dist
redfishtool-1.0.5-py3-none-any.whl  redfishtool-1.0.5.tar.gz
$ twine upload dist/redfishtool-1.0.5-py3-none-any.whl dist/redfishtool-1.0.5.tar.gz  # upload for both packages
thombashi commented 6 years ago

When I created this issue, I failed redfishtool package installation via pip but looks like it comes from my environment error, I can install the package on a new clean Python environment.