search

DMTF / Redfishtool

A Python34 program that implements a command line tool for accessing the Redfish API.
Other
224 stars 68 forks source link

Add Lowercase Version Long Option #66

Closed vice closed 5 years ago

mraineri commented 5 years ago

Any particular reason for the change?

vice commented 5 years ago

To be consistent with the options help text: https://github.com/DMTF/Redfishtool/blob/844c0b9c51cd7b42e5ed3d9ba4ff19e1dcccc618/redfishtool/redfishtoolMain.py#L38

And because usually long options are lowercase.

mraineri commented 5 years ago

Ah, good catch; never noticed that discrepancy!

billdodd commented 5 years ago

Since the code has been like this for a long time it might be nice to be sure we still accept the original long arg:

elif opt in ("-V", "--version", "--Version"):

Just in the unlikely case that someone has a script that is collecting the tool version using '--Version'.

mraineri commented 5 years ago

Approved 6/6