search

DMTF / SPDM-Responder-Validator

BSD 3-Clause "New" or "Revised" License
10 stars 14 forks source link

Need to check `Case 9.6` in `9.FinishRsp` #89

Closed lazineer closed 1 year ago

lazineer commented 1 year ago

According to Table 61 - FINISH request message format, DSP0274, Param2 is reserved, if Param1 is not set.

Param2 is descrived like below.

SlotID. Only valid if Param1 = 0x01, otherwise reserved.

In Case 9.6, I think it needs to change the 'Param1.Sig' from 0 to 1 to get InvalidRequest. If Param1.sig is 0 like Case 9.6 currently, I think the responder has to response a correct FINISH_RSP.

Could you check what I wrote above?

jyao1 commented 1 year ago

Case 9.6 is "Description: SPDM responder shall return ERROR(UnexpectedRequest), if it receives a FINISH before KEY_EXCHANGE."

Without KEY_EXCHANGE, how can you get a correct FINISH_RSP ?

lazineer commented 1 year ago

There are two Case 9.6s in 9.FinishRsp. What you mentioned is next to Case 9.3. It has had incorrect number. What I mentioned is "Description: SPDM responder shall return ERROR(InvalidRequest), if it receives a FINISH with invalid field." and it is next to Case 9.5.

jyao1 commented 1 year ago

Ah, I think you are right.