search

DMTF / YANG-to-Redfish-Converter

This tool converts a YANG model file to the corresponding Redfish schema, specified in OData CSDL, in accordance with the YANG-to-CSDL Mapping Specification.
Other
4 stars 5 forks source link

Migrated changes unmerged in previous repo... #1

Closed tomasg2012 closed 6 years ago

tomasg2012 commented 6 years ago

changes include: Handlers now all use similar arguments Fixed grammar/logic for Revision, Status, Reference Fixed Identity Temporary preprocessing fix to comment removal issues with certain YANG files fixed Augment places generated info in its own xml files

mraineri commented 6 years ago

From 12/14: Will let @jcleung5549 test this before accepting

jcleung5549 commented 6 years ago

The resultant xml files have a regression. In annotations, the 'Term' field should come first. In the output below, the Description annotate has the 'Term' field last.

<NavigationProperty Name="interfacesContainer" ContainsTarget="True" Type="interfaces.interfaces">
    <Annotation Term="OData.Permissions" EnumMember="OData.Permissions/Read"/>
    <Annotation String="Navigation property that points to a resource of interfaces." Term="OData.Description"/>
    <Annotation String="Automatically generated." Term="OData.LongDescription"/>
    <Annotation Term="AutoExpandReferences"/>
</NavigationProperty>
jcleung5549 commented 6 years ago

The problem is not in the converter, it's in the application used to view the XML file. Explorer and Edge reorder the attributes. VIM or Notepad preserve the ordering.

Merge approved.

mraineri commented 6 years ago

Approved 1/4