search

DMTF / libspdm

BSD 3-Clause "New" or "Revised" License
104 stars 100 forks source link

Cmake Modernization #2722

Closed alexteoh-intel closed 3 months ago

alexteoh-intel commented 4 months ago

This PR aims to modernize CMake code in this repo. For example, we're moving away from global functions (include_directories) that impact all targets.

Coding style here is based on Effective Modern CMake, which was referred by https://cliutils.gitlab.io/modern-cmake/chapters/intro/dodonot.html.

Other misc changes:

steven-bellock commented 3 months ago

@alexteoh-intel is this ready for review?

alexteoh-intel commented 3 months ago

@alexteoh-intel is this ready for review?

Hi @steven-bellock, thanks it's not yet ready. I'm still testing locally with an outside cmake project and calibrating the changes required.

alexteoh-intel commented 3 months ago

Closing PR for now. I'm planning propose only a portion of the changes from this PR.