When testing illegal parameters on public Requester functions libspdm_requester_*_test_send_message and libspdm_requester_*_test_receive_message usually returns LIBSPDM_STATUS_SUCCESS for that case. However this is misleading as libspdm_requester_*_test_*_message should not be called for that case and it should be considered an implementation bug if it is called. For example
When testing illegal parameters on public Requester functions
libspdm_requester_*_test_send_messageandlibspdm_requester_*_test_receive_messageusually returnsLIBSPDM_STATUS_SUCCESSfor that case. However this is misleading aslibspdm_requester_*_test_*_messageshould not be called for that case and it should be considered an implementation bug if it is called. For examplehttps://github.com/DMTF/libspdm/blob/4b0a3c570f84a7ef244596ea6c472d934479b699/unit_test/test_spdm_requester/error_test/get_measurements_err.c#L3238-L3241 and https://github.com/DMTF/libspdm/blob/4b0a3c570f84a7ef244596ea6c472d934479b699/unit_test/test_spdm_requester/error_test/get_measurements_err.c#L148-L149 cmocka's
assert_true(false);should be hit before returning from the function.