DMTF / python-redfish-library

Python3 library for interacting with devices that support a Redfish service
Other
168 stars 181 forks source link

Fixed issue where the 'read' method on response objects always return strings #126

Closed mraineri closed 2 years ago

mraineri commented 2 years ago

Fix #125

I looked further at the history of some of the response methods, and this is what I can gather:

When converting to use requests, read was erroneously changed to always return a string. However, one thing worth noting is if someone is using the mechanisms in place to set data in the response object, read will be converted to a string. We should look at this further to ensure consistency, but that might break usage for others. The functionality we have in this PR is equivalent to what we had prior to moving to requests.

ldonova1992 commented 2 years ago

Fix has been tested and passes. Everything looks good, thanks!

jautor commented 2 years ago

Approved 5/6