DMTF / spdm-emu

BSD 3-Clause "New" or "Revised" License
31 stars 42 forks source link

spdm_responder_lib cannot identify capability conflict of DATA_TRANSFER_SIZE and MAX_SPDM_MSG_SIZE for SPDM version 1.0 & 1.1 #329

Open owen126315 opened 8 months ago

owen126315 commented 8 months ago

I ran the spdm_responder_validator test case 7.1 with below Responder settings:

Requester

Responder

The _libspdm_get_responsecapabilities seems cannot detect the conflict while handling get capability. How should the responder handle this?

steven-bellock commented 8 months ago

What SPDM version(s) does the Requester support? If it's the https://github.com/DMTF/SPDM-Responder-Validator then it cannot talk to a 1.3-only Responder since we haven't updated Responder Validator to 1.3 yet.

owen126315 commented 8 months ago

The problem still here even responder is 1.2.

owen126315 commented 8 months ago

I guess the root cause is can both requester and responder support chunk, not SPDM version. the DATA_TRANSFER_SIZE and MAX_SPDM_MSG_SIZE must be equal if chunk is not support. And libspdm_get_response_capabilities never check these two parameters when request.version = 1.0.

steven-bellock commented 8 months ago

Those two fields, and chunking, did not exist until SPDM 1.2.