search

DMarby / picsum-photos

Lorem Ipsum... but for photos.
https://picsum.photos
MIT License
2.2k stars 152 forks source link

Category Filter #81

Closed danilosandoval closed 1 year ago

danilosandoval commented 3 years ago

Hi Guys! Love this. Consider add category param to get a photo as a ?category=virtual-reality Can I help?

mholt commented 1 year ago

Can you help us understand why this isn't planned, @DMarby? Would you accept a contribution?

DMarby commented 1 year ago

Hi @mholt,

There's two main reasons:

First, the work of going over all our source images to add useful tags to them would be quite a bit of work, and so it's not something I've been able to prioritize doing myself.

Second, given that our source image pool is fairly small (just shy of 1000 images), I am not sure how useful this feature is overall, given that most tags would presumably only have a handful of images?

The source images Picsum uses were collected before Unsplash had an API (Picsum started out as unsplash.it back when Unsplash was still a tumblr blog, as an unofficial api), and used the CC0 license for all images. They have since changed to a new license incompatible with our use, hence why we are not able to add more images from Unsplash or use their tags for existing ones.

If someone would be willing to do the work of manually tagging all the images in our image manifest, I'd be happy to implement the functionality however.

mholt commented 1 year ago

Ohhh, that makes sense. Thanks for the background!

(My use case is a bunch of fake "persons" in a demo database, and needing profile pictures, which naturally should be of people.)

matbrgz commented 8 months ago

Noo problem, I can handle that. The unspash provide a category list, I can put this information in an array. Does it make sense? If it happens, you could implement this?

Print image

Array example Image https://unsplash.com/photos/man-in-front-of-laptop-computer-in-shallow-focus-photography-LNRyGwIJr5c

Image manifest

{
            "id": "1",
            "author": "Alejandro Escamilla",
            "width": 5000,
            "height": 3333,
            "url": "https://unsplash.com/photos/LNRyGwIJr5c"
            "category": ["Work","Blog","Working","Technology","Typing","Website Backgrounds","Business","Man","Hd Mac Wallpapers","Hd Macbook Wallpapers","Apple Images & Photos","Macbook Pro","Write","Desk","Office","Writing","Table","Coffee Images","Cell Phone","Clean","HD Wallpapers",],
},

This make sense?

DMarby commented 8 months ago

Hi @matbrgz, as mentioned in https://github.com/DMarby/picsum-photos/issues/81#issuecomment-1340068800 we can't use any data from Unsplash due to their licensing, so all images would need to be manually tagged independently.