DMcP89 / harambot

A Yahoo Fantasy Sports bot for Discord

MIT License

29 stars 18 forks source link

Add check for setting.LOGLEVEL to models.py #163

Closed FarhanaAfrin closed 2 months ago

FarhanaAfrin commented 2 months ago

Update setup.cfg to include package data and find packages correctly
Add MANIFEST.in to specify inclusion of config files (settings.toml, example.secrets.toml)
Update config.py to dynamically load configuration files from the correct path

Description

Types of Changes

[ ] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization

Issues Fixed or Closed by This PR

157

Checklist

[x] My code follows the code style of this project: [Python]()
[x] I have read the [PR Checklist document]() and have made the appropriate changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the [CONTRIBUTING document]().
[ ] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

DMcP89 commented 2 months ago

hi @FarhanaAfrin

Thanks so much for your interest in Harambot and thanks for taking the time to submit a PR. However this particular issue was already addressed in the recent v0.4.1 release.

https://github.com/DMcP89/harambot/blob/main/harambot/database/models.py#L11-L14

As for the setting.toml and secrets.toml they will be phased out in a future release so for now we are just going to leave the config.py file be.