search

DNAlchemist / ssskins

Mod allows to set custom skins location url on the server side
Apache License 2.0
9 stars 3 forks source link

Mod fails to work as server-side only on 1.12.2 #12

Open fnpngn opened 1 year ago

fnpngn commented 1 year ago

1.12.2 Latest Forge Version 2860 throws 

Server Mod rejections:
Server Side Skins: Requires version 0.0.1 but mod is not found on the client

When attempting to connect to a server of the same forge version running the mod while not having it installed on the client. No fix found, posting an issue for further reference.

Tested with older mod builds to no avail

fnpngn commented 1 year ago

Figured the connection was refused because Forge now requires acceptableRemoteVersions="*" property in the @Mod annotation. After spending significantly more time to set up the build process I managed to join the server without the error, but the mod wouldn't function, so the issue remains. Since the change is not worthy of a pull request I will leave the solution here, but the problem remains.

Many debug lines later here is the conclusion: The mod seems to be changing players' render texture, but I really struggle to understand how that would work, since it does not run on the client machine and the server would not trigger the Render Event callback. Testing it with server-only and server + client proved that the client would only recieve the skin and/or render it if the mod is installed on the client (hence the onPlayerRender event gets triggered)