DNNCommunity / DNN.Feedback

DNN Feedback is a basic module used for accepting user inquiries on your DNN site.
MIT License
17 stars 16 forks source link

Message limited to 10 characters after upgrade to DNN 9.4.1 #51

Closed WHairstonLOI closed 4 years ago

WHairstonLOI commented 4 years ago

Describe the bug

A clear and concise description of what the bug is. After upgrading our site from DNN 9.1.1 to DNN 9.4.1, the message body text control is limited to only 10 characters. Looking at the HTML of the page, the generated textarea element has a maxlength=10 attribute, although the size of the message field is set to contain up to 1000 characters in the module settings.

Software Versions

To Reproduce

Steps to reproduce the behavior:

  1. Go to our site at https://www.logicaloperators.com/Contact-Us
  2. Click on Message Body in Feedback form
  3. Start typing. You can only enter 10 characters.
  4. See error: examine HTML of page

Expected behavior

A clear and concise description of what you expected to happen. Expect to be able to enter the number of characters configured.

Screenshots

If applicable, add screenshots to help explain your problem. N/A

Error log

Note: Debug DLL's Please replace the current extension DLL's with the debug DLL's (if these are available with the release) and reproduce the error with the debug DLL's before pasting the error log. N/A

Paste the error log that is related to this issue. N/A

Additional context

Add any other context about the problem here. N/A

WHairstonLOI commented 4 years ago

Sorry, but I couldn't leave our site crippled like that. I "temporarily" fixed the issue on our site by editing the Feedback.ascx file to change the message body's hard-coded maxlength=10 to maxlength=1000.

However, this problem DOES appear to be new to DNN 9.4.x, as I have the same version of the extension running on client sites as recent as DNN 9.3.2; although the maxlength=10 attribute is hard-coded into their sites' Feedback.ascx files too, it does not appear in their generated HTML.

valadas commented 4 years ago

Wow, I am surprised this was not spotted earlier, I do see that maxLenght in the ascx. Odd.

Well there is a documented workaround to edit that file, but certainly something to fix on next release.

WHairstonLOI commented 4 years ago

I didn’t really have a chance to look deeper last night, but as previously noted, I have that same version of the module running as expected on other client sites that are based on DNN 9.3.2 or lower and they all run WITHOUT generating the maxlength attribute in the resulting HTML (although the maxlength attribute is present in their Feedback.ascx files). Does the attribute get adjusted somewhere in code before the HTML is generated?

valadas commented 4 years ago

Yes, there is a setting for it. I only have a french instance right now to look at so the labels I mention here might be a bit off, but under:

Module Settings -> Form and Fields Settings -> Message maximum lenght

And I believe this overrides the maxLenght of that field. Now I still think 10 for a default is kinda short, we should at least make the default 250 or some such, 10 is ridiculous for any message.

thebowenmango commented 4 years ago

Hi Team, I found it was the first row that had the 10 character limit. If you hit enter, you lose the 10 character limit on the subsequent lines.

ChrisHammond commented 4 years ago

I found that my site is experiencing this as well.

image

Even though the setting is 1000 characters, always limited to 10. Doesn't matter if you hit enter or not in the text field, still limited.

njhvidberg commented 4 years ago

Hi Just installed ver. 6.6.2 and it still has the error. Any new version on its way? I can add that the number of characters remaining is acting on the specified Max Message Length settings.

sleupold commented 4 years ago

there is an open PR to fix it.

valadas commented 4 years ago

Resolved in 6.6.3 which I will publish in a minute...