search

DNNCommunity / DNN.Reports

DNN Reports module provides a simple, flexible, view on your database, any table, any view and display results with plugin visualizers
MIT License
21 stars 25 forks source link

Cache duration isn't applied to the cache object #89

Open arampendley opened 9 months ago

arampendley commented 9 months ago

Describe the bug

Cache duration isn't applied to the cache object

To Reproduce

Steps to reproduce the behavior:

  1. Go to Module Settings
  2. Enter a cache duration of 10 minutes
  3. Close editor
  4. View page

Expected behavior

The cache object should be cleared and reloaded after 10 minutes

Add me as a contributor and I will fix this.

valadas commented 9 months ago

@arampendley you can send a PR and I'll be happy to review/merge/release. If you plan on doing multiple PRs let me know and I can wait for a few before a release. Thanks.

arampendley commented 9 months ago

Great, thank you. Can you add me as a contributor so I can create a branch to do the work? Thanks,Aram On Monday, December 4, 2023 at 10:33:04 AM PST, Daniel Valadas @.***> wrote:

@arampendley you can send a PR and I'll be happy to review/merge/release. If you plan on doing multiple PRs let me know and I can wait for a few before a release. Thanks.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

valadas commented 9 months ago

You can fork the repository to create a branch in your fork to submit a PR.

arampendley commented 9 months ago

Ok thank you. I will work on this next week. On Monday, December 4, 2023 at 12:54:22 PM PST, Daniel Valadas @.***> wrote:

You can fork the repository to create a branch in your fork to submit a PR.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>