Add test in case of the settings isn't set due to module upgrade

DNNCommunity / DNN.Repository

DNN.Repository is a rich module used for managing and displaying rich collections of images, files, llinks, etc. on your DNN site. Includes user rating, comments, templating and skinning.

MIT License

8 stars 14 forks source link

Add test in case of the settings isn't set due to module upgrade #59

Closed stetard closed 11 months ago

stetard commented 1 year ago

Closes #57

Just add a test in case of the setting doesn't exist in the database. It could occurs on old Repository modules after an upgrade.

PR Template Checklist

[x] Fixes Bug
[ ] Feature solution
[ ] Other

Please mark which issue is solved

Close #57

valadas commented 11 months ago

@stetard I read the whole PR, I see a lot of refactoring but not seeing any meaningful change, did I miss something, can you point me to the line number where the fix starts?

valadas commented 11 months ago

Oh, I reread and found it, merging. It would make it easier/quicker to review if major style refactorings and the bugfix are done in separate commits.

stetard commented 11 months ago

OK Daniel Thanks for your feedback.