search

DNNCommunity / DNN.Vendors

The Vendors module project allows admins to manage Vendor relationships and add Advertising banners to their site.
MIT License
7 stars 10 forks source link

HTML5 Conformance #27

Closed Andy9999 closed 4 years ago

Andy9999 commented 4 years ago

Hi!

If using the banner module, it seems to render invalid HTML5:

Error: The cellspacing attribute on the table element is obsolete. Use CSS instead. From line 191, column 3; to line 191, column 114 <table id="dnn_ctr6136_DisplayBanners_lstBanners" cellspacing="0" cellpadding="4" summary="Banner Design Table">

Error: The cellpadding attribute on the table element is obsolete. Use CSS instead. From line 191, column 3; to line 191, column 114 <table id="dnn_ctr6136_DisplayBanners_lstBanners" cellspacing="0" cellpadding="4" summary="Banner Design Table">

Error: The summary attribute on the table element is obsolete. Consider describing the structure of the table in a caption element or in a figure element containing the table; or, simplify the structure of the table so that no description is needed. From line 191, column 3; to line 191, column 114 <table id="dnn_ctr6136_DisplayBanners_lstBanners" cellspacing="0" cellpadding="4" summary="Banner Design Table">

The table could possibly get replaced by a HTML5 datalist. Here are some examples:: https://stackoverflow.com/questions/16131946/html-5-datalist-option https://stackoverflow.com/questions/15628415/binding-data-to-html5-datalist-in-asp-net

Alternatively, it could be made possible to not render those 3 attributes (cellspacing, cellpadding and summary) and then set those in the stylesheet.

Andy9999

Andy9999 commented 4 years ago

This issue can be closed. The bug was sitting in front of the display. For some reason I had it configured to legacy mode. I now have it running on DNN 9.4.1. :)

After switching to template mode and adjusting the settings properly it was rendering no more HTML4 stuff. It even works with multiple installed languages if defining a banner group for each language.

Before we had it configured to script and I switched to banner mode. I also had to switch from site mode to host mode. In site mode, no banner was displayed for some reason. If site mode is enabled, I could not select banner JPG files from the site in the vendors module. Instead it was still displaying the "Host Root" folder, without any possibility to get to the site files. This stuff could be caused by our DNN installation. I did not try it on a clean DNN install.

Andy9999