search

DNNCommunity / DNNDocs

The documentation site for the open source Content Management System DNN (formerly DotNetNuke).
https://docs.dnncommunity.org
23 stars 51 forks source link

Localization Issue #486 #666

Closed SmallMistake closed 2 years ago

SmallMistake commented 2 years ago

Continuation of the request for help translating a blog on Localization to a guide under the content management tab: https://github.com/DNNCommunity/DNNDocs/issues/486 (Localization)

I based it largely off of the guide outlined in the thread and my very limited experience so I might have overlooked something. Let me know if there are any areas that you think need any more explanation.

SmallMistake commented 2 years ago

Fixed Image Links by including images with project

valadas commented 2 years ago

@david-poindexter is /images/something.jpg ok here or do they need to be ../images/something.jpg ?

SmallMistake commented 2 years ago

I don't know for sure. I just copied what another page was doing and flipped it into preview mode to make sure it works. Since it worked in preview mode it probably should be fine.

david-poindexter commented 2 years ago

@valadas as a reminder, we still have this CI/CD issue to look into to ensure success with publishing this. I had forgotten that, so let me know when you have some time and we can double-team this one. I think we should hold off merging this until we get the build issue resolved. Otherwise, it will not be published on the site.

valadas commented 2 years ago

@david-poindexter yeah, I honestly don't remember what the issue was, I'll submit a test PR just to get fresh build logs as the existing ones expired :)