DNNCommunity / Dnn.CommunityForums

Open-source forums module for DNN Platform. This is a fork and continuance of the Active Forums module.
https://dnncommunity.org
Other
13 stars 21 forks source link

Handle copy pasted images #38

Open Timo-Breumelhof opened 3 years ago

Timo-Breumelhof commented 3 years ago

Is your feature request related to a problem?

Please describe.

-- Edit This was before the editor updates in DNN. The issue is now this: https://github.com/dnnsoftware/Dnn.Platform/issues/5415 So what we need to check is if we can make the files upload to the user folder. -- /Edit

The CKEditor allows a user to copy and paste images in the editor, these end up as base 64 in the HTML. IMO it would be good to extract them and store them in the user folder (if pasting image is allowed) as having them as base 64 in the HTML is not optimal IMO.

Describe the solution you'd like

Extract base 64 images from the saved source HTML and save them to the user folder using a guid.

Describe alternatives you've considered

Block pasting of images

Timo-Breumelhof commented 3 years ago

I guess a max size setting for these images would be good too? Or maybe this should be a separate setting..

WillStrohl commented 3 years ago

Is this an issue that should be handled by forums or by the actual CKEditor?

https://github.com/DNN-Connect/CKEditorProvider

Timo-Breumelhof commented 3 years ago

We could do both, but my initial though was to process the posted HTML by Forums as for those posts it's quite obvious where you would want to place the physical files I think. For CKEditor, that is less obvious IMO.

WillStrohl commented 3 years ago

So, for the primary editor, you're thinking that it should have a slightly different location, such as [user folder root]/images and the forums might be something like [user folder root]/forum/images. Is that what you're thinking? Also, is this part of the provider itself, or does it depend on a specific provider?

WillStrohl commented 3 years ago

Depending on how it can be implemented, we could even make it easier to find files and prevent overwrites... [user folder root]/forum/post/12345/images

Timo-Breumelhof commented 3 years ago

Depending on how it can be implemented, we could even make it easier to find files and prevent overwrites... [user folder root]/forum/post/12345/images

Yes, I like that. I think it's so specific that we should handles this in the module?

WillStrohl commented 3 years ago

Yes. That looks to be so.

Timo-Breumelhof commented 1 year ago

@WillStrohl @johnhenley I was on my way to log this for the editor and found this: https://github.com/dnnsoftware/Dnn.Platform/issues/5415

mitchelsellers commented 1 year ago

Given the way the HTML Editor Provider works, and current configuration ability of the provider. Customization of the drop location even if dnnsoftware/Dnn.Platform#5415 is resolved, a user specific folder isn't going to be a specific supported configuration option.

The CKEditor provider has abilities to customize the provider for a particular page/module, but it only has a single-static root folder selection.

For something such as this, I strongly recommend this being addressed IN the module, rather than using the regular DNN Provided one, due to a number of considerations.

Just my $0.02

Timo-Breumelhof commented 1 year ago

@mitchelsellers we have not looked into this from a technical point of view, but the way for instance Open Content handles this is that you can manipulate the settings of the editor from the template. That could be a solution..

WillStrohl commented 1 year ago

@mitchelsellers we have not looked into this from a technical point of view, but the way for instance Open Content handles this is that you can manipulate the settings of the editor from the template. That could be a solution..

Ah! That editor has so many hidden features that I can't keep up with it. 😵

WillStrohl commented 1 year ago

@mitchelsellers As Timo mentioned, we're still collaborating here with everyone in the open at this point. So thank you so much for the feedback, and please keep it coming whenever you're so inspired. :)