search

DNNCommunity / Dnn.CommunityForums

Open-source forums module for DNN Platform. This is a fork and continuance of the Active Forums module.
https://dnncommunity.org
Other
13 stars 21 forks source link

INSTALLER: Don't rename themes/module.css during an 08.00.00 upgrade #441

Closed johnhenley closed 1 year ago

johnhenley commented 1 year ago

Describe the bug

Correct an issue encountered related to #229 during 08.00.00 upgrade testing.

In the 08.00.00 release, themes/theme.css is loaded and is applied prior to any theme. This file is delivered during installation of DNN Community Forums, It may be overwritten during upgrades, and should not be updated by site administrators.

It can be overridden by declaring CSS in the theme.css located in a theme-specific folder and the /custom/theme.css.

Community Forums's CSS Load order: 1) ~/DesktopModules/ActiveForums/module.css 2) ~/DesktopModules/ActiveForums/themes/theme.css 3) ~/DesktopModules/ActiveForums/themes/<currenttheme>/theme.css 4) ~/DesktopModules/ActiveForums/themes/<currenttheme>/custom/theme.css

During an 8.0 install, a new themes/theme.css file gets installed. However, if it's an upgrade, any existing themes/module.css gets renamed to theme.css, so the new theme.css gets overwritten ☹

Software Versions

To Reproduce

Steps to reproduce the behavior:

  1. Upgrade existing 07.00.x site to 08.00.00
  2. module.css will be renamed to theme.css
  3. new theme.css content is not there

Expected behavior

  1. Leave existing module.css intact.
  2. Install new themes/theme.css and continue loading it
  3. If users want to move portions of their CSS from module.css to themes.css, that is their option.
  4. Include note in release notes image
Timo-Breumelhof commented 1 year ago

@johnhenley I just tested with this fix and now my Theme looks nearly the same after an upgrade. Small icons size fixes that seems to be it