DNNCommunity / Dnn.CommunityForums

Open-source forums module for DNN Platform. This is a fork and continuance of the Active Forums module.
https://dnncommunity.org
Other
13 stars 21 forks source link

ENH: community-default theme shows extra icon #937

Closed Timo-Breumelhof closed 2 months ago

Timo-Breumelhof commented 2 months ago

Is your feature request related to a problem?

On the community site there's an issue with the Icons:

image

This is from TopicsView

That's weird because on my local test site this is not visible:


image

Describe the solution you'd like

Fix is :-)

Timo-Breumelhof commented 2 months ago

HTML:

image

Timo-Breumelhof commented 2 months ago

not the resource file..

https://github.com/DNNCommunity/Dnn.CommunityForums/blob/8d57f485d63682a6583f4ef5b79483fcd715b50e/Dnn.CommunityForums/App_LocalResources/SharedResources.resx#L1675

Timo-Breumelhof commented 2 months ago

So I guess it;s this   we see, but why?

https://github.com/DNNCommunity/Dnn.CommunityForums/blob/8d57f485d63682a6583f4ef5b79483fcd715b50e/Dnn.CommunityForums/themes/community-default/templates/TopicsView.ascx#L13C158-L13C164

johnhenley commented 2 months ago

HTML:

image

image

Timo-Breumelhof commented 2 months ago

@johnhenley right, but why is the space parsed to something else?

Timo-Breumelhof commented 2 months ago

@johnhenley Hmm @WillStrohl edited a file on the server.. maybe it was this one.. I'll check the server

Timo-Breumelhof commented 2 months ago

@johnhenley

image

johnhenley commented 2 months ago

I think you're onto something ...

Hang on.

This is what it looks like encoded: image

And this is a stackoverflow answer about that character sequence image

If you edit from the control panel (not an editor), replace the unprintable character with  

Timo-Breumelhof commented 2 months ago

@johnhenley I edited it on the server and replaced the char with  , cleared the cache and now it's "fixed"

Timo-Breumelhof commented 2 months ago

@johnhenley but now check out what the CP editor does:

image

It interprets the   I think..?

Timo-Breumelhof commented 2 months ago

Yes, saving replaces  with the "character"

Timo-Breumelhof commented 2 months ago

@johnhenley I'll create another issue for the cause of this

WillStrohl commented 2 months ago

Whoa... Nice find!