search

DNNCommunity / Dnn.StructuredContent

This is a proof of concept for a structured content solution for DNN Platform (formerly known as DotNetNuke). This should not be used in a production environment. Anything can change at this stage of development.
Other
13 stars 5 forks source link

Fix variable name to follow proper convention #67

Closed X3Technology closed 2 years ago

X3Technology commented 2 years ago

This PR refactors all of the table names, column names, variable name to follow the proper naming conventions. Almost every file is touched in some way....

resolves #60

WillStrohl commented 2 years ago

I haven't had as much experience with this code as some of you, so I'm wondering something that most of you may already know the answer to...

Why do we have two different installation scripts?

One is the DAL\Install.SqlDataProvider and is lacking all of the updates in the DBScripts\00.01.00.SqlDataProvider file that we've been working on.

[EDIT] FYI - The manifest is only looking at the DBScripts version.
[/EDIT]

X3Technology commented 2 years ago

Hold off on that. The taes have changed significantly...

Sent via the Samsung Galaxy S20 5G, an AT&T 5G smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Will Strohl @.> Sent: Monday, September 20, 2021 7:01:31 PM To: DNNCommunity/Dnn.StructuredContent @.> Cc: Jay Mathis @.>; Assign @.> Subject: Re: [DNNCommunity/Dnn.StructuredContent] Fix variable name to follow proper convention (#67)

I haven't had as much experience with this code as some of you, so I'm wondering something that most of you may already know the answer to...

Why do we have two different installation scripts?

One is the DAL\Install.SqlDataProvider and is lacking all of the updates in the DBScripts\00.01.00.SqlDataProvider file that we've been working on.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/DNNCommunity/Dnn.StructuredContent/pull/67#issuecomment-923415772, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAMDENJ7KTXSN55KTVX7VPLUC64MXANCNFSM5EM5QMNA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

david-poindexter commented 2 years ago

This PR is going to need to be rebased (due to changes to DBScripts/00.01.00.SqlDataProvider) before it can be merged.