flamethrower message not accurate if -Q option is passed

DNS-OARC / flamethrower

a DNS performance and functional testing utility supporting UDP, TCP, DoT and DoH

Apache License 2.0

319 stars 37 forks source link

flamethrower message not accurate if -Q option is passed #61

Open leshow opened 3 years ago

leshow commented 3 years ago

❯ flame 0.0.0.0 -p 9953 -Q 10   
flaming target "0.0.0.0" (0.0.0.0) on port 9953 with 10 concurrent generators, each sending 10 queries every 1ms on protocol udp

"10 concurrent generators, each sending 10 queries every 1ms on protocol udp" is not accurate if flamethrower is only sending 10 queries per second, 10 generators * 10 queries/ms is 100,000 QPS. Unless I'm missing something here, this message should change based the -Q parameter?

weyrick commented 3 years ago

Interesting, yes I can see how that's confusing. It's actually not inaccurate - the rate limiting with -Q is applied at the end of the "pipeline", so indeed all of those generators are sending queries at the advertised rate and then they are limited to 10 QPS. I will flag this as a bug to make the message clearer. Thanks for the report!