DNS-OARC / ripeatlas

Go bindings for RIPE Atlas API
MIT License
11 stars 12 forks source link

Add first version of fetching metadata (msm/prb) #20

Closed astrikos closed 6 years ago

astrikos commented 6 years ago

Hey @jelu, that's a first try of implementing fetching metadata of measurements & probes. I am not sure if I can integrate it inside atlaser interface, so if you have any suggestions or feedback let me know and I can adapt. I was thinking in making getProbes & getMeasurements into helper functions inside code but I wasn't really sure. Also next step is to add also some logic to accept parameters to filter down searches, but currently you can specify it inside the url.

jelu commented 6 years ago

Thanks, I am currently not in a position to do any coding so I will get back to you on this in a few weeks.

About getting it into Atlaser, if the calls exist for both live backends it should be no problem as long as the objects returned are compatible and then use the parameters for any uniques. (more on this later)

jelu commented 6 years ago

@astrikos I've reworked the code, please have a look at the new examples.

astrikos commented 6 years ago

@jelu give me couple of days to digest :)

jelu commented 6 years ago

@astrikos No problem!

astrikos commented 6 years ago

Seems good to me in general!