Can't build because yacc command not found

kowalcj0 commented 5 years ago

Hi,

I just pulled latest changes and I'm getting this error

docker build -t dnscrypt-server:2019.02.05 .
...
yacc -d -o util/configparser.c ./util/configparser.y
/bin/bash: yacc: command not found
make: *** [Makefile:446: util/configparser.h] Error 127
....

To fix this I had to add byacc or bison to ENV BUILD_DEPS. If you decide to go with:

byacc then 20170709-r0 version will be installed
bison then 3.0.4-r0 will be installed which is a pretty dated one https://pkgs.alpinelinux.org/package/v3.4/main/x86/bison

It'd be good to fix this issue by adding missing dependency

Cheers

jedisct1 commented 5 years ago

Good catch!

Could you submit a pull request adding one of these dependencies?

mibere commented 5 years ago

Can be closed?!

see https://github.com/DNSCrypt/dnscrypt-server-docker/commit/e29cf6d90e7210ee1d84855b10863f0c61f5d5b7

jedisct1 commented 5 years ago

Yep.

kowalcj0 commented 5 years ago

thank you for fixing and sorry for late reply!

DNSCrypt / dnscrypt-server-docker

Can't build because yacc command not found #54