DNSCrypt / dnscrypt-server-docker

A Docker image for a non-censoring, non-logging, DNSSEC-capable, DNSCrypt-enabled DNS resolver
https://dnscrypt.info
ISC License
670 stars 135 forks source link

changes to guide #75

Closed ooonea closed 5 years ago

ooonea commented 5 years ago

Hi, I saw that there were important changes to the guide. Some things have improved, but I also see missing parts. For example, the part that explains how to delete the container and the corresponding disk image is missing, while only mention is made of the elimination of the container while preserving the data. Then another important thing is missing, namely the command to restart the container automatically when the server is restarted (docker update --restart = unless-stopped dnscrypt-server). So I think it's partly to be reviewed, but it can't be changed directly for other users on GitHub like it is for dnscrypt-proxy.

jedisct1 commented 5 years ago

Hi!

Yes, using mounted volumes should makes things easier, especially updates.

Is docker update --restart=unless-stopped required if the --restart=unless-stopped option was already provided when the container was created? I thought it was redundant, but maybe not! I don't use Docker that much.

A section on how to delete both the image and the container will be added.

You should have commit access to the repository, if you want to make changes directly :)

ooonea commented 5 years ago

Is docker update --restart=unless-stopped required if the --restart=unless-stopped option was already provided when the container was created?

Thank you for giving me the opportunity to contribute to the guide. In fact the above command does just what I was looking for. If I saw something to change I will let you know.