DNSSEC-Provisioning / music

Multi-Signer Controller (MuSiC)
5 stars 5 forks source link

Join add cds cleanup #197

Closed romu42 closed 1 year ago

romu42 commented 1 year ago

136 triggered this PR, I went through the code. It was fine, but I updated the Variables to make it easier to follow the logic.

romu42 commented 1 year ago

from the go 1.17 spec If the last iteration variable is the blank identifier, the range clause is equivalent to the same clause without that identifier.

That being said, I put it back for readability.

romu42 commented 1 year ago

closes #136

romu42 commented 1 year ago

The change of the variable names is to make it easier to follow the code, I find it easier now at least. An issue was opened stating that the code was not robust. When reading the code I found it difficult to follow and decided to clean up the variable naming a bit. If you don't find this helpful or important I am interested to hear any alternatives to a better way to make such changes with out you having to do a review.