DNXLabs / terraform-aws-client-vpn

This terraform module installs a client VPN.
https://modules.dnx.one
Apache License 2.0
48 stars 54 forks source link

Add an option to enable self-service portal #14

Open AustinZhu opened 2 years ago

AustinZhu commented 2 years ago

Contact Details (optional)

No response

Summary

Option to enable self-service portal in Client VPN module, alongside with an output of the URL of the portal.

Motivation

Self-service portal is commonly enabled in the setup of a client VPN endpoint.

Alternatives

No response

Additional Context

No response

Code of Conduct

sparkinson commented 7 months ago

Hello,

This appears to be half done as there is an enable_self_service_portal input variable. But I think we also need one more variable for the "Self-service SAML provider ARN" and to add this to the authorization config when we have enable_self_service_portal set to true.

I'd be happy to help and create a PR with this change if that is useful

adenot commented 1 month ago

hi @sparkinson, we assumed it would use the saml_provider_arn for the self-service portal when enabled, if that's not the case, I'd appreciate if you send a PR with the changes.