DNXLabs / terraform-aws-client-vpn

This terraform module installs a client VPN.
https://modules.dnx.one
Apache License 2.0
48 stars 54 forks source link

Mark outputted keys as sensitive #22

Open toMeloos opened 1 year ago

toMeloos commented 1 year ago

The module is failing on Terraform 1.0 because as of 0.14 sensitive outputs must be marked as such. This PR aims to fix that.

To reduce the risk of accidentally exporting sensitive data that was intended to be only internal, Terraform requires that any root module output containing sensitive data be explicitly marked as sensitive, to confirm your intent. If you do intend to export this data, annotate the output value as sensitive by adding the sensitive = true argument.

Types of changes

What types of changes does your code introduce to ? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

Full Terragrunt error log:

│ Error: Output refers to sensitive values
│ 
│   on _outputs.tf line 10:
│   10: output "vpn_client_key" {
│ 
│ To reduce the risk of accidentally exporting sensitive data that was
│ intended to be only internal, Terraform requires that any root module
│ output containing sensitive data be explicitly marked as sensitive, to
│ confirm your intent.
│ 
│ If you do intend to export this data, annotate the output value as
│ sensitive by adding the following argument:
│     sensitive = true
╵
╷
│ Error: Output refers to sensitive values
│ 
│   on _outputs.tf line 16:
│   16: output "vpn_server_key" {
│ 
│ To reduce the risk of accidentally exporting sensitive data that was
│ intended to be only internal, Terraform requires that any root module
│ output containing sensitive data be explicitly marked as sensitive, to
│ confirm your intent.
│ 
│ If you do intend to export this data, annotate the output value as
│ sensitive by adding the following argument:
│     sensitive = true
╵
╷
│ Error: Output refers to sensitive values
│ 
│   on _outputs.tf line 22:
│   22: output "vpn_ca_key" {
│ 
│ To reduce the risk of accidentally exporting sensitive data that was
│ intended to be only internal, Terraform requires that any root module
│ output containing sensitive data be explicitly marked as sensitive, to
│ confirm your intent.
│ 
│ If you do intend to export this data, annotate the output value as
│ sensitive by adding the following argument:
│     sensitive = true