DNXLabs / terraform-aws-client-vpn

This terraform module installs a client VPN.
https://modules.dnx.one
Apache License 2.0
48 stars 54 forks source link

Fix/warning #24

Closed mcosta1105 closed 1 year ago

mcosta1105 commented 1 year ago

Updated security group ids argument to remove the warning below.

Warning: Argument is deprecated

with module.vpn[0].aws_ec2_client_vpn_network_association.default[0],
on modules/terraform-aws-client-vpn/vpn-endpoint.tf line 34, in resource "aws_ec2_client_vpn_network_association" "default":
34:   security_groups        = [var.security_group_id == "" ? aws_security_group.default[0].id : var.security_group_id]

Use the `security_group_ids` attribute of the `aws_ec2_client_vpn_endpoint` resource instead.

Types of changes

What types of changes does your code introduce to ? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...