DNXLabs / terraform-aws-ecs

This terraform module builds an Elastic Container Service(ECS) Cluster in AWS.
https://modules.dnx.one/
Apache License 2.0
29 stars 31 forks source link

Adding optional egress sg rule to ALB, needed for OIDC authentication #32

Closed adenot closed 3 years ago

adenot commented 3 years ago

This is needed since ALBs try to reach an external HTTPS endpoint when using the OIDC authentication action.

Types of changes

What types of changes does your code introduce to ? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.