DNXLabs / terraform-aws-ecs

This terraform module builds an Elastic Container Service(ECS) Cluster in AWS.
https://modules.dnx.one/
Apache License 2.0
29 stars 31 forks source link

feature(waf): add support for WAF V2 logging and sampling #36

Closed rmartin48 closed 2 years ago

rmartin48 commented 2 years ago

Resolves https://github.com/DNXLabs/terraform-aws-ecs/issues/35

Adding support for WAFv2 logging and sampling for the ALB. It is important get detailed information about traffic that is analysed by the WAF web ACLs in order to evaluate the rules groups and make improvements.

Types of changes

What types of changes does your code introduce to ? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

rmartin48 commented 2 years ago

Closing this as it is better implement customisation of the WAF in your own terraform config. Particularly when needing things like rule exclusions.