DNXLabs / terraform-aws-network

Terraform module for creating basic network resources: VPC, subnets and NAT.
https://modules.dnx.one
Apache License 2.0
5 stars 18 forks source link

Add aws-cdk:subnet-name and aws-cdk:subnet-type tags to subnets #21

Closed nicklaw5 closed 3 years ago

nicklaw5 commented 3 years ago

This PR sees that the aws-cdk:subnet-name and aws-cdk:subnet-type tags are added to all provisioned subnets. These tags are require by AWS CDK for resolving subnets on an existing deployed VPCs. See the docs for further details.

Types of changes

What types of changes does your code introduce to ? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

It's up for debate as to whether or not we add these tags based if a specific boolean variable is defined.