search

DNedic / lockfree

A collection of lock-free data structures written in standard C++11
MIT License
795 stars 49 forks source link

Priority Queue Multithreaded Test #15

Closed DrDub closed 10 months ago

DrDub commented 10 months ago

I looked at your other test cases, hopefully this one works well out of the box.

DNedic commented 10 months ago

Thanks for the contribution @DrDub , unfortunately the code is not very readable and clear in my opinion. Perhaps you could refactor it or comment on the intended behavior.

Of course, it doesn't have to match code readability of the library code as it's a test, but I feel uncomfortable adding this test as it would be hard to debug quickly.

DrDub commented 10 months ago

Thanks for taking the time to explain.

Your other test cases are short and self-documenting. I couldn't come up with a multi-threaded test on par with that so I guess this test case will have to be explicitly documented. I have added a few paragraphs of text and will be happy to add more or we can discuss the merits of the approach.

One of the nice things of documenting it is that I realized I could spare one of the loops so it is tighter now :+1:

DNedic commented 10 months ago

Thank you for your contribution @DrDub! I will be also pushing a commit with some cleanups so you can watch out for that if you're interested after the merge.

DrDub commented 10 months ago

Sure, will do! It seems #4 is close to completion by now.