DOAJ / doaj

The Directory of Open Access Journals - website and directory software
Apache License 2.0
59 stars 16 forks source link

Author processing charge anomaly #155

Closed dommitchell closed 10 years ago

dommitchell commented 10 years ago

We have a bug I think but hoping that you can explain this away:

1) go to http://bit.ly/1fqwegD 2) APC information for Pakistan Journal of Analytical and Environmental Chemistry shows NO APCs and a link 3) click Edit this journal and you will see that the APC question is blank with no link 4) Add the APC info (which you have to because it is compulsory) and the link. Hit Submit 5) Refresh page http://bit.ly/1fqwegD and click Edit the journal 6) APC info is missing again.

What's going on?

emanuil-tolev commented 10 years ago

The development of the new suggestion form entailed a new data model for journal information. The way the data is stored - the structure - is shared across journals and suggestions since that part of the data is exactly the same.

Basically the new structure with the 40+ pieces of info does not store APC information in the same way the old structure used to. Due to the otherwise very nice reuse of the model, both journals and suggestions got affected by this.

It is of course possible to operate based on both the old and the new data model - that's what the site's been doing so far anyway (after we rolled out the new suggestion form). But this had slipped our attention.

It is fixed for now, you can edit APC info on the live site. (@richard-jones this won't affect existing or new suggestions or journals adversely. I just reenabled a deprecated function in the models, but the journal edit form is the only place it's used.) Also, of course, the whole journal admin form is getting replaced with one relying on the new data model pretty soon anyhow.

No actual APC information on the live site has been lost Dom - and you would have noticed your changes not getting applied, as you say it's a required field...