Feature/3933 autocheck keepers update

[richard-jones]

• Issue: https://github.com/DOAJ/doajPM/issues/3933

---

Reorganise Keepers Registry check for more complete advice

Keepers Registry check now checks all values available in the form, not just those selected by the user

This PR...

• [ ] has scripts to run
• [ ] has migrations to run
• [ ] adds new infrastructure
• [ ] changes the CI pipeline
• [ ] affects the public site
• [x] affects the editorial area
• [ ] affects the publisher area
• [ ] affects the monitoring

Developer Checklist

Developers should review and confirm each of these items before requesting review

• [ ] Code meets acceptance criteria from issue
• [x] Unit tests are written and all pass
• [x] User Test Scripts (if required) are written and have been run through
• [x] Project's coding standards are met
  • No deprecated methods are used
  • No magic strings/numbers - all strings are in constants or messages files
  • ES queries are wrapped in a Query object rather than inlined in the code
  • Where possible our common library functions have been used (e.g. dates manipulated via dates)
  • Cleaned up commented out code, etc
  • Urls are constructed with url_for not hard-coded
• [x] Code documentation and related non-code documentation has all been updated
  • Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
  • Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
• [x] Migation has been created and tested
• [x] There is a recent merge from develop

Reviewer Checklist

Reviewers should review and confirm each of these items before approval If there are multiple reviewers, this section should be duplicated for each reviewer

• [ ] Code meets acceptance criteria from issue
• [ ] Unit tests are written and all pass
• [ ] User Test Scripts (if required) are written and have been run through
• [ ] Project's coding standards are met
  • No deprecated methods are used
  • No magic strings/numbers - all strings are in constants or messages files
  • ES queries are wrapped in a Query object rather than inlined in the code
  • Where possible our common library functions have been used (e.g. dates manipulated via dates)
  • Cleaned up commented out code, etc
  • Urls are constructed with url_for not hard-coded
• [ ] Code documentation and related non-code documentation has all been updated
  • Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
  • Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
• [ ] Migation has been created and tested
• [ ] There is a recent merge from develop

Testing

Both autocheck functional tests:

https://doaj.github.io/doaj-docs/feature/3933_autocheck_keepers_update/testbook/index.html#autocheck/application_submission_workflow

https://doaj.github.io/doaj-docs/feature/3933_autocheck_keepers_update/testbook/index.html#autocheck/autocheck

Deployment

N/A