Reviewers should review and confirm each of these items before approvalIf there are multiple reviewers, this section should be duplicated for each reviewer
[ ] Code meets acceptance criteria from issue
[ ] Unit tests are written and all pass
[ ] User Test Scripts (if required) are written and have been run through
[ ] Project's coding standards are met
No deprecated methods are used
No magic strings/numbers - all strings are in constants or messages files
ES queries are wrapped in a Query object rather than inlined in the code
Where possible our common library functions have been used (e.g. dates manipulated via dates)
Cleaned up commented out code, etc
Urls are constructed with url_for not hard-coded
[ ] Code documentation and related non-code documentation has all been updated
update bg monitoring settings for mission critical monitoring changes
Applies tighter monitoring constraints on the background jobs, as per this spreadsheet: https://docs.google.com/spreadsheets/d/1XWq-7R9hZmZsBA27eOgs9cO-SfJnLEE0dW50DVtKhpI/edit?gid=543591434#gid=543591434
This PR...
Developer Checklist
Developers should review and confirm each of these items before requesting review
constants
ormessages
filesdates
)url_for
not hard-codeddevelop
Reviewer Checklist
Reviewers should review and confirm each of these items before approval If there are multiple reviewers, this section should be duplicated for each reviewer
constants
ormessages
filesdates
)url_for
not hard-codeddevelop
Testing
This tightens the monitoring on a number of bg jobs, so would be good to validate that this won't cause any major surge in unnecessary reporting.
Probably need to send it live and then adjust.
Deployment
Configuration changes
Adds new values in:
Monitoring
This may trigger new types of "unstable" alerts in the background jobs reporting, so we should ensure that those alerts come through