enforce consistency between has_apc and the apc data itself

has_apc = False did not cause the apc data in the record to be removed, which was resulting in an inconsistent record, and oddities in display

This PR...

[ ] has scripts to run
[ ] has migrations to run
[ ] adds new infrastructure
[ ] changes the CI pipeline
[x] affects the public site
[ ] affects the editorial area
[ ] affects the publisher area
[ ] affects the monitoring

Developer Checklist

Developers should review and confirm each of these items before requesting review

[x] Code meets acceptance criteria from issue
[x] Unit tests are written and all pass ~* [ ] User Test Scripts (if required) are written and have been run through~
[x] Project's coding standards are met
- No deprecated methods are used
- No magic strings/numbers - all strings are in constants or messages files
- ES queries are wrapped in a Query object rather than inlined in the code
- Where possible our common library functions have been used (e.g. dates manipulated via dates)
- Cleaned up commented out code, etc
- Urls are constructed with url_for not hard-coded
[x] Code documentation and related non-code documentation has all been updated
- Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
- Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
[x] Migation has been created and tested
[x] There is a recent merge from develop

Reviewer Checklist

Reviewers should review and confirm each of these items before approval If there are multiple reviewers, this section should be duplicated for each reviewer

[ ] Code meets acceptance criteria from issue
[ ] Unit tests are written and all pass
[ ] User Test Scripts (if required) are written and have been run through
[ ] Project's coding standards are met
- No deprecated methods are used
- No magic strings/numbers - all strings are in constants or messages files
- ES queries are wrapped in a Query object rather than inlined in the code
- Where possible our common library functions have been used (e.g. dates manipulated via dates)
- Cleaned up commented out code, etc
- Urls are constructed with url_for not hard-coded
[ ] Code documentation and related non-code documentation has all been updated
- Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
- Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
[ ] Migation has been created and tested
[ ] There is a recent merge from develop

Testing

No test scripts to be run. Nonetheless, I was unable to reproduce this issue locally via the forms, and would need a crafted CSV to demonstrate the issue, which I don't have. The fix is therefore speculative in the sense that I have not been able to produce the issue locally and then demonstrate that this fixes it. If it's possible to replicate live on test and run the migration to show the fix, that would be very useful.

Deployment

Migrations

See:

portality/migrate/20241031_4005_apc_model_consistency/

DOAJ / doaj